Add new post processing filter - rotation filter #13499
Conversation
|
Great work overall :) |
|
Please check the CI failure, looks related to this changes |
Nir-Az
changed the title
|
Remember to try to add this filter to our post processing example and to a python unit test |
… of should process
noacoohen
force-pushed
the
rotate_depth_frames
branch
from
9368665 to
c0dc22e
Compare
| vs = create_video_stream(depth_intrinsics) | ||
| depth_stream_profile = depth_sensor.add_video_stream(vs) | ||
|
|
||
| sync = rs.syncer() |
| @@ -269,11 +272,29 @@ void render_ui(float w, float h, std::vector<filter_options>& filters) | |||
| ImGui::Checkbox(filter.filter_name.c_str(), &tmp_value); | |||
| filter.is_enabled = tmp_value; | |||
| ImGui::PopStyleColor(); | |||
|
|
|||
|
|
|||
| if( filter.filter_name == "Rotate" ) // Combo box specifically for the rotation filter | |||
There was a problem hiding this comment.
I wonder why rotate is the only one needs special handling,
Is it because we added a special option for it?
What is the value of RS2_OPTION_FILTER_MAGNITUDE for other filters?
Is it always 1,2,3,4 ?
If not maybe we could have used it for 90/-90/180?
There was a problem hiding this comment.
Because the rest of the options use filter_slider_ui which is set up for continuous values, but we need discrete 90-degree increments.
|
Is this compatible with the ROS 2 wrapper? I need to rotate my images from two D455 cameras then detect april tags and human presence. If it is how can I use it? |
How do we use this filter? I need to rotate 90 degrees in a ROS 2 based application. Can I pass the filter in with my launch command? |
|
Hi, currently, this filter isn’t enabled in ROS 2, but it’s a great idea, and we plan to add support for it soon. |
This PR introduce a new post processing filter for rotating depth frames 90,180,-90 degrees.
This feature can be handy when installing the camera rotated.
Tracked-by RSDSO-19843