Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use no soversion #1487

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Use no soversion #1487

merged 1 commit into from
Aug 5, 2024

Conversation

ZzEeKkAa
Copy link
Collaborator

@ZzEeKkAa ZzEeKkAa commented Aug 3, 2024

Adapt changes to IntelPython/dpctl#1773

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Aug 3, 2024
@ZzEeKkAa ZzEeKkAa enabled auto-merge August 3, 2024 03:45
@ZzEeKkAa
Copy link
Collaborator Author

ZzEeKkAa commented Aug 3, 2024

CI is red because of dpnp. It must be rebuilt first.

@ZzEeKkAa
Copy link
Collaborator Author

ZzEeKkAa commented Aug 5, 2024

Triggered rebuild. @oleksandr-pavlyk could you take a look, please?

@ZzEeKkAa ZzEeKkAa requested a review from diptorupd August 5, 2024 15:13
oleksandr-pavlyk
oleksandr-pavlyk approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The change to abandon use of SO-versioning in DPCTLSyclInterface to simplify Python packaging for dpctl.

@ZzEeKkAa ZzEeKkAa merged commit 252e7d9 into main Aug 5, 2024
45 of 52 checks passed
@ZzEeKkAa ZzEeKkAa deleted the fix/use_no_soversion branch August 5, 2024 19:15
github-actions bot added a commit that referenced this pull request Aug 5, 2024
@github-actions
Merge pull request #1487 from IntelPython/fix/use_no_soversion
414e4bd 
Use no soversion 252e7d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @oleksandr-pavlyk