Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not selectively apply spirv exts unconditionally do so in spirv_generator #1383

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Do not selectively apply spirv exts unconditionally do so in spirv_generator #1383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_atomic_ref_overloads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@
MemoryScope,
)
from numba_dpex.kernel_api.flag_enum import FlagEnum
from numba_dpex.kernel_api_impl.spirv.target import (
CC_SPIR_FUNC,
LLVM_SPIRV_ARGS,
)
from numba_dpex.kernel_api_impl.spirv.target import CC_SPIR_FUNC

from ...core.types.kernel_api.atomic_ref import AtomicRefType
from ..target import DPEX_KERNEL_EXP_TARGET_NAME
Expand Down Expand Up @@ -100,15 +97,6 @@ def gen(context, builder, sig, args):
atomic_ref_ty
).get_field_position("ref")

# TODO: evaluating the llvm-spirv flags that dpcpp uses
context.extra_compile_options[LLVM_SPIRV_ARGS] = [
"--spirv-ext=+SPV_EXT_shader_atomic_float_add"
]

context.extra_compile_options[LLVM_SPIRV_ARGS] = [
"--spirv-ext=+SPV_EXT_shader_atomic_float_min_max"
]

ptr_type = retty.as_pointer()
ptr_type.addrspace = atomic_ref_ty.address_space

Expand Down
Loading