Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use dpnp specific parfor #1290

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jan 22, 2024

Introduce dpjit/dpnp specific pass. Instead of patching numba function update all call tree to generate right call. This unblocked setting dpnp specific instructions.

Checklist:

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Fixes: #1270
Fixes: #146

@ZzEeKkAa ZzEeKkAa requested a review from diptorupd January 22, 2024 18:29
@ZzEeKkAa ZzEeKkAa self-assigned this Jan 22, 2024
@diptorupd
Copy link
Contributor

@ZzEeKkAa overall the approach is good. I suggest you explore one thing. Instead of completely duplicating the upstream ParforPass and using our version of the upstream pass, maybe we create a supplementary pass. Our pass runs after the upstream pass and does the extra analysis that is needed to identify as parfor nodes dpnp array expressions that are missed by the upstream pass. The benefit of doing so, if we are able to do it that is, will be lesser maintenance overhead on our part.

@diptorupd
Copy link
Contributor

Our pass runs after the upstream pass and does the extra analysis that is needed to identify as parfor nodes dpnp array expressions that are missed by the upstream pass.

That is just doConvertDPNPPass(self).run(self.func_ir.blocks)

@diptorupd diptorupd added this to the 0.23 milestone Feb 29, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_dpnp_specific_parfor branch 2 times, most recently from 328fb38 to 92e0bb3 Compare March 29, 2024 16:58
@coveralls
Copy link
Collaborator

coveralls commented Mar 29, 2024

Coverage Status

coverage: 84.819% (-0.06%) from 84.874%
when pulling a0d78df on feature/use_dpnp_specific_parfor
into 778bde3 on main.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_dpnp_specific_parfor branch from 92e0bb3 to 7c16c51 Compare March 29, 2024 17:20
@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_dpnp_specific_parfor branch from 7c16c51 to a0d78df Compare March 29, 2024 18:02
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd March 29, 2024 18:02
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review March 29, 2024 18:02
@ZzEeKkAa ZzEeKkAa merged commit b6a13b0 into main Mar 29, 2024
39 of 42 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/use_dpnp_specific_parfor branch March 29, 2024 18:41
github-actions bot added a commit that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants