Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up experimental launcher #1231

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Clean up experimental launcher #1231

merged 1 commit into from
Dec 1, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Nov 30, 2023 •
edited
Loading

Code restructuring to achieve encapsulation and simplify logic. Some comments where added for easier navigation.

It is not perfect, but better than it was

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Nov 30, 2023
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner November 30, 2023 19:35
@ZzEeKkAa ZzEeKkAa force-pushed the feature/clean_experimental_launcher branch from 69b0998 to 4c8f1d1 Compare November 30, 2023 19:50
@ZzEeKkAa ZzEeKkAa force-pushed the feature/clean_experimental_launcher branch 2 times, most recently from b7db7f7 to 32fef0b Compare December 1, 2023 04:22
@ZzEeKkAa ZzEeKkAa enabled auto-merge December 1, 2023 16:06
@ZzEeKkAa ZzEeKkAa force-pushed the feature/clean_experimental_launcher branch from 32fef0b to 2b52a19 Compare December 1, 2023 16:06
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd December 1, 2023 16:07
diptorupd
diptorupd approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The changes made the launcher module better organized than before. We are laying a good foundation for these new features.

@ZzEeKkAa ZzEeKkAa merged commit a62ff1a into main Dec 1, 2023
29 of 34 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/clean_experimental_launcher branch December 1, 2023 16:33
github-actions bot added a commit that referenced this pull request Dec 1, 2023
@github-actions
Merge pull request #1231 from IntelPython/feature/clean_experimental_…
b6c7516 
…launcher

Clean up experimental launcher a62ff1a
github-actions bot added a commit to chudur-budur/numba-dpex that referenced this pull request Dec 5, 2023
@github-actions
Merge pull request IntelPython#1231 from IntelPython/feature/clean_ex…
7e96386 
…perimental_launcher

Clean up experimental launcher a62ff1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd