-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove atomic emulation #1103
Remove atomic emulation #1103
Conversation
dc1d1c1
to
e8253e2
Compare
e8253e2
to
e751744
Compare
e751744
to
743de4b
Compare
5eb17ca
to
f323f73
Compare
This PR should unblock these checks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The run_test.sh
script in the conda-recipe
directory should be updated as well.
The documentation page
https://github.com/IntelPython/numba-dpex/blob/main/docs/source/user_guide/kernel_programming/atomic-operations.rst should be updated as well.
@ZzEeKkAa in a subsequent PR can you push changes to remove the dependency on spirv-tools? |
f323f73
to
7d9bcca
Compare
Documentation preview: show. |
e28ea8b
to
0f05392
Compare
#650 tested: > set NUMBA_DPPY_DEBUG=1
> dpbench -b gpairs -i numba_dpex_k run --no-skip-expected-failures
================ Benchmark GPairs (gpairs) ========================
================ implementation numba_dpex_k ========================
implementation: numba_dpex_k
framework: numba_dpex
framework version: 0.21.1+61.g7d9bcca0.dirty
input size: 8512
setup time: 219.6217ms (219621700 ns)
warmup time: 962.5928ms (962592800 ns)
teardown time: 101.4μs (101400 ns)
max execution times: 4.226ms (4226000 ns)
min execution times: 2.7134ms (2713400 ns)
median execution times: 3.15995ms (3159950 ns)
repeats: 10
preset: S
validated: Success |
#1068 tested: python test_1068.py
Using device ...
Device(level_zero:gpu:0)
Reduction sum = 11.
Done... |
0f05392
to
167def8
Compare
Documentation preview removed. |
Did it here in a separate commit. |
…tion Remove atomic emulation ead772d
Since DPCPP now supports atomics, we don't need to emulate them by ourselves.
Fixes: #760
Fixes: #650
Fixes: #868
Fixes: #1068