Update Windows version used by GitHub CI #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtavana
requested review from
ndgrigorian,
antonwolfy,
xaleryb and
ekomarova
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions Windows runner to windows-latest ahead of the Windows Server 2019 retirement and adds an MSVC setup step so cl.exe is available.
- Switch Windows CI image from
windows-2019towindows-latest - Insert
Setup MSVCaction for proper MSVC environment configuration - Update matrix
runnerentries to match the new image
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/conda-package.yml | Updated runs-on and matrix runner, added MSVC setup step before building the conda package. |
| .github/workflows/conda-package-cf.yml | Applied the same runner update, matrix runner adjustment, and MSVC setup insertion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows Server 2019 image will be removed on 2025-06-30 actions/runner-images#12045 and currently there is a scheduled Windows Server 2019 brownout.
In this PR, windows-latest is used in GitHub Actions.
In addition, a step is added to Setup MSVC otherwise
cl.exeis not recognized.error: command 'cl.exe' failed: None