Skip to content

update test to pass with numpy-2.3 #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

update test to pass with numpy-2.3 #2477

wants to merge 5 commits into from

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jun 10, 2025 •
edited by antonwolfy
Loading

Tests are updated to have a green CI with numpy-2.3.0.

  1. matmul failure is because a bug in NumPy.
  2. numpy.unique is modified in numpy-2.3, dpnp should align with recent changes.
  3. There was a bug for calculating norm of empty arrays when keepdims=True is passed which is fixed.
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Jun 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2477/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_13 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@vtavana vtavana force-pushed the fix-numpy-2.3 branch 4 times, most recently from 96cf11b to 2320a26 Compare June 10, 2025 22:20
@vtavana vtavana marked this pull request as ready for review June 11, 2025 02:17
@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jun 11, 2025
antonwolfy
antonwolfy approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few minor comments, but in overall LGTM
Thank you @vtavana for adopting dpnp with numpy 2.3 and reporting identified issues.

@vtavana vtavana requested a review from antonwolfy June 13, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy