Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuning gpairs implementation params #341

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

adarshyoga
Copy link
Contributor

@adarshyoga adarshyoga commented Feb 21, 2024

  • Have you provided a meaningful PR description?

The gpairs implementation parameters like work group size and private memory size was initially tuned for integrated graphics devices. This PR updates the parameters determined from running experiments on Intel Datacenter Max GPUs.

CURRENT:

================ Benchmark GPairs (gpairs) ========================

WARNING:root:numba_dpex needs at least numba 0.58.0 but no more than 0.59.0, using numba=0.59.0 may cause unexpected behavior
================ implementation numba_dpex_k ========================
implementation: numba_dpex_k
framework: numba_dpex
framework version: 0.22.0.dev2+3.g59d523892
input size: 33554752
setup time: 485.043436ms (485043436 ns)
warmup time: 376.657913892s (376657913892 ns)
teardown time: 0ns (0 ns)
max execution times: 366.524516362s (366524516362 ns)
min execution times: 366.524516362s (366524516362 ns)
median execution times: 366.524516362s (366524516362 ns)
repeats: 1
preset: L
validated: Not Validated
================ implementation sycl ========================
implementation: sycl
framework: dpcpp
framework version: IntelLLVM 2024.0.0
input size: 33554752
setup time: 132.39452ms (132394520 ns)
warmup time: 240.888781093s (240888781093 ns)
teardown time: 0ns (0 ns)
max execution times: 243.165765882s (243165765882 ns)
min execution times: 243.165765882s (243165765882 ns)
median execution times: 243.165765882s (243165765882 ns)
repeats: 1
preset: L
validated: Not Validated

AFTER THIS CHANGE:

================ Benchmark GPairs (gpairs) ========================

WARNING:root:numba_dpex needs at least numba 0.58.0 but no more than 0.59.0, using numba=0.59.0 may cause unexpected behavior
================ implementation numba_dpex_k ========================
implementation: numba_dpex_k
framework: numba_dpex
framework version: 0.22.0.dev2+3.g59d523892
input size: 33554752
setup time: 364.385996ms (364385996 ns)
warmup time: 221.568546643s (221568546643 ns)
teardown time: 0ns (0 ns)
max execution times: 220.188768653s (220188768653 ns)
min execution times: 220.188768653s (220188768653 ns)
median execution times: 220.188768653s (220188768653 ns)
repeats: 1
preset: L
validated: Not Validated
================ implementation sycl ========================
implementation: sycl
framework: dpcpp
framework version: IntelLLVM 2024.0.0
input size: 33554752
setup time: 130.867229ms (130867229 ns)
warmup time: 217.880147619s (217880147619 ns)
teardown time: 0ns (0 ns)
max execution times: 218.045546452s (218045546452 ns)
min execution times: 218.045546452s (218045546452 ns)
median execution times: 218.045546452s (218045546452 ns)
repeats: 1
preset: L
validated: Not Validated

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@adarshyoga adarshyoga self-assigned this Feb 21, 2024
@adarshyoga adarshyoga force-pushed the feature/switch_to_new_dpex_kernel branch from 7f42e7e to 2cd28e7 Compare February 21, 2024 17:13
@adarshyoga adarshyoga force-pushed the fix/tune_gpairs_params branch from 2149e34 to e9ee048 Compare February 21, 2024 17:13
@adarshyoga adarshyoga force-pushed the feature/switch_to_new_dpex_kernel branch from 2cd28e7 to 54d5aab Compare February 21, 2024 17:53
@adarshyoga adarshyoga force-pushed the fix/tune_gpairs_params branch from e9ee048 to b03b473 Compare February 21, 2024 17:54
Base automatically changed from feature/switch_to_new_dpex_kernel to main February 21, 2024 20:18
@diptorupd diptorupd force-pushed the fix/tune_gpairs_params branch from b03b473 to 5913150 Compare February 21, 2024 20:19
@diptorupd diptorupd force-pushed the fix/tune_gpairs_params branch from 5913150 to 7cb267a Compare February 23, 2024 19:40
@adarshyoga adarshyoga merged commit 9e30fa0 into main Feb 23, 2024
45 checks passed
@adarshyoga adarshyoga deleted the fix/tune_gpairs_params branch February 23, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants