Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for single precision execution of knn sycl implementation #334

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix for single precision execution of knn sycl implementation #334

merged 1 commit into from
Feb 23, 2024

Conversation

adarshyoga
Copy link
Contributor

@adarshyoga adarshyoga commented Feb 8, 2024 •
edited
Loading

  • Have you provided a meaningful PR description?

Fixed failure in sycl implementation when executed with single precision input.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@adarshyoga adarshyoga changed the title Removing expected failure for knn sycl implementation Fix for single precision execution of knn sycl implementation Feb 8, 2024
@adarshyoga adarshyoga self-assigned this Feb 8, 2024
@adarshyoga adarshyoga force-pushed the fix/knn_exp_failure branch 3 times, most recently from 1eddd9b to 40cd383 Compare February 21, 2024 00:26
@adarshyoga adarshyoga requested a review from diptorupd February 21, 2024 00:27
@adarshyoga adarshyoga force-pushed the fix/knn_exp_failure branch 3 times, most recently from 5764024 to 8ac6528 Compare February 21, 2024 20:20
@diptorupd diptorupd self-requested a review February 23, 2024 19:09
@diptorupd diptorupd enabled auto-merge February 23, 2024 19:10
@diptorupd diptorupd merged commit 8128dd2 into main Feb 23, 2024
45 checks passed
@diptorupd diptorupd deleted the fix/knn_exp_failure branch February 23, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@adarshyoga adarshyoga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adarshyoga @diptorupd