Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload wheel to the same version #304

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Upload wheel to the same version #304

merged 1 commit into from
Oct 10, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Oct 10, 2023 •
edited
Loading

Wheels are uploaded to the version from wheels package that comes from versioner. That version is different for wheel and Conda and contains GitHub stash. That results into junk in Conda registry version list. PR simply uploads same wheel to the version of Conda package.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Oct 10, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the fix/wheel_upload branch 3 times, most recently from 9ac93f0 to 17bf4bc Compare October 10, 2023 19:43
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review October 10, 2023 21:03
@ZzEeKkAa ZzEeKkAa merged commit f62f074 into main Oct 10, 2023
@ZzEeKkAa ZzEeKkAa deleted the fix/wheel_upload branch October 10, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ZzEeKkAa