Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HNSW to DescriptorSet Engine enum #233

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Add HNSW to DescriptorSet Engine enum #233

merged 2 commits into from
Oct 14, 2024

Conversation

cwlacewe
Copy link
Contributor

No description provided.

@cwlacewe cwlacewe linked an issue Oct 14, 2024 that may be closed by this pull request
@cwlacewe cwlacewe requested a review from s-gobriel October 14, 2024 19:00
s-gobriel
s-gobriel previously approved these changes Oct 14, 2024
Copy link
Contributor

@s-gobriel s-gobriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@rolandoquesada rolandoquesada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

Target CPP Coverage: 63.8504%
Source CPP Coverage: 63.8504%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@cwlacewe cwlacewe merged commit 9ac17e3 into develop Oct 14, 2024
7 checks passed
@cwlacewe cwlacewe deleted the hnsw_fix branch October 14, 2024 20:50
cwlacewe added a commit that referenced this pull request Oct 14, 2024
* Add HNSW to DescriptorSet Engine enum (#233)

* Update enum in api_schema.json and add client test using hnsw

* remove artifact

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Michael Beale <[email protected]>
Co-authored-by: Ian Adams <[email protected]>
Co-authored-by: sys_vdms <[email protected]>
Co-authored-by: Rohit Verma <[email protected]>
Co-authored-by: Sameh Gobriel <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cwlacewe cwlacewe added this to the v2.10.0 Tasks milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FaissHNSWFlat missing from enum
3 participants