Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ManualGradientClip hook #255

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

laserkelvin
Copy link
Collaborator

This PR fixes an error due to Lightning's API changes to the on_before_optimizer_step hook, which no longer requires an optimizer index to be passed.

@laserkelvin laserkelvin added the bug Something isn't working label Jul 18, 2024
@laserkelvin laserkelvin requested a review from melo-gonzo July 18, 2024 18:55
@laserkelvin laserkelvin merged commit 4851287 into IntelLabs:main Jul 19, 2024
3 checks passed
@laserkelvin laserkelvin deleted the grad-clip-fix branch July 22, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants