Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint Path Check Bugfix #219

Merged
merged 7 commits into from
May 17, 2024

Conversation

melo-gonzo
Copy link
Collaborator

@melo-gonzo melo-gonzo commented May 17, 2024

The checkpoint check from #215 was not working as expected. Somthing about how __ functions get tied up with the class in which they are associated with (mangling). This PR fixes this issue by making it a single underscore.

  File "./matsciml/examples/interfaces/ase_from_pretrained.py", line 24, in <module>
    calc = MatSciMLCalculator.from_pretrained_force_regression(
  File "./matsciml/matsciml/interfaces/ase/base.py", line 264, in from_pretrained_force_regression
    ckpt_path = __checkpoint_conversion_exist_check(ckpt_path)
NameError: name '_MatSciMLCalculator__checkpoint_conversion_exist_check' is not defined

@melo-gonzo melo-gonzo requested a review from laserkelvin May 17, 2024 17:15
Copy link
Collaborator

@laserkelvin laserkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - I did the double underscore intentionally to make it private but didn't expect it to actually break things

@laserkelvin laserkelvin merged commit 6b2bcb0 into IntelLabs:main May 17, 2024
3 checks passed
@melo-gonzo melo-gonzo deleted the checkpoint-check-bugfix branch May 17, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants