Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external sources feature. #5

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

rguarascia
Copy link
Contributor

This gives the ability to load from external JSON's or directly from the Github main JSON itself. This enables users to get the latest index.json, without having to update the package just to get a new list of domains. Furthermore this enables users to load from an external source, such as a CDN within their organization.

I have updated the test to reflect the new options field, and have also added a customer error class to enable clean catches.

Copy link
Contributor

deepsource-io bot commented Feb 22, 2025

Here's the code health analysis summary for commits c057ab2..ae592bb. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 9 occurences introduced
🎯 1 occurence resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@IntegerAlex
Copy link
Owner

Thank you for your contribution, It adds great flexibility with external source support while maintaining backward compatibility. If it doesn't break code for others i am happy.

@IntegerAlex IntegerAlex merged commit ee99133 into IntegerAlex:main Feb 22, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants