Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

Add support for dropping tables #5

Open
wants to merge 3 commits into
base: rocks_3.0
Choose a base branch
from

Conversation

hashbrowncipher
Copy link

This branch enables support for dropping tables. In addition do that, it:

  • changes the capitalization of cfId to match the rest of the Cassandra codebase
  • namespaces tables on-disk by cfId, so that tables which are dropped and re-created with the same name have different on-disk locations.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@keshavdv
Copy link

Thanks for contributing! Do you mind rebasing -- we've since added optional RocksDB shards within the RocksDBCF so there are multiple instances where the table needs to be dropped. Can you also provide a more concrete migration path for users with existing non-UUID filepaths?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants