Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcst.tool: add support Python 3.9, 3.10, 3.11, 3.12 and 3.13 #1229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jorenham
Copy link

Currently, running e.g. libcst.tool codemod --python-version=3.9 ... will raise a ValueError with the message:

ValueError: LibCST can only parse code using one of the following versions of Python's grammar: 3.0, 3.1, 3.3, 3.5, 3.6, 3.7, 3.8. More versions may be supported by future releases.

This adds the missing supported python version strings.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2024
@zsol
Copy link
Member

zsol commented Dec 7, 2024

Unfortunately that flag doesn't actually do anything anymore by default1, so I'd rather remove it.

Footnotes

  1. It only controls the behavior of the old, unmaintained pure python parser which you can enable with an environment variable. That parser doesn't support 3.9 or newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants