Add explicit activesupport version as CocoaPods dependency
#1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimOliver
changed the title
activesupport version as CocoaPods dependency
|
@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@TimOliver merged this pull request in 2bdbc12. |
GreeMoz
pushed a commit
to appintheair/IGListKit
that referenced
this pull request
Jan 31, 2024
…am#1590) Summary: ## Changes in this pull request All of the tests started failing today with a cryptic Ruby error. It turns out that a new version of `activesupport`, a dependency of CocoaPods was released and it introduced a bug. CocoaPods wasn't referencing a direct version of `activesupport` required, and so it was automatically trying to pull in this new invalid version. This PR fixes the issue by explicitly specifying the last known good version of the dependency in the `Gemfile`. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1590 Test Plan: Tested and confirmed on my own fork of IGListKit this resolves the CocoaPods issue Reviewed By: fabiomassimo Differential Revision: D50013182 Pulled By: TimOliver fbshipit-source-id: 623eab49dea5ff0b589b6f06ce589e99873dece4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
All of the tests started failing today with a cryptic Ruby error. It turns out that a new version of
activesupport, a dependency of CocoaPods was released and it introduced a bug. CocoaPods wasn't referencing a direct version ofactivesupportrequired, and so it was automatically trying to pull in this new invalid version.This PR fixes the issue by explicitly specifying the last known good version of the dependency in the
Gemfile.Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.