Skip to content

Commit

Permalink
Fix UI test timeout when running on GitHub Actions
Browse files Browse the repository at this point in the history
Summary:
The previous CI changes landed this morning, however there was still some test flakiness. From the logs, it looked like an Accessibility dialog was being shown during the UI tests, and this was causing them to time out.

On closer inspection of the logs , I discovered the 'pre-heat' step in the UI tests pipeline was incorrectly choosing the wrong iPhone 14 Pro simulator, since GitHub Actions on macOS 13 offers both iOS 16.4 and iOS 17.0 devices (Even if Xcode 14 was explicitly declared).

In order to ensure the same iOS Simulator is used throughout the UI tests, this diff explicitly declares the iOS version it expects to be working with.

Differential Revision: D51293930

fbshipit-source-id: ddeee7a6aa8f826541bc1aeb56ed6a8445534694
  • Loading branch information
TimOliver authored and facebook-github-bot committed Nov 20, 2023
1 parent a4bae43 commit f99d861
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ jobs:
EXAMPLE_SCHEME: IGListKitExamples
strategy:
matrix:
iosDestination: ["platform=iOS Simulator,name=iPhone 14 Pro"]
iosDestination: ["platform=iOS Simulator,name=iPhone 14 Pro,OS=16.4"]
tvOSDestination: ["platform=tvOS Simulator,name=Apple TV 4K (3rd generation)"]
macOSDestination: ["platform=macOS"]
macCatalystDestination: ["platform=macOS,variant=Mac Catalyst"]
Expand All @@ -227,7 +227,7 @@ jobs:
uses: futureware-tech/simulator-action@v2
with:
model: 'iPhone 14 Pro'
os_version: '>=16.0'
os_version: '=16.4'

- name: Build iOS Example - ${{ matrix.iosDestination }}
run: |
Expand Down Expand Up @@ -279,4 +279,4 @@ jobs:

- name: Run Danger
run: bundle exec danger --verbose

0 comments on commit f99d861

Please sign in to comment.