-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGP-83 #94
base: main
Are you sure you want to change the base?
Conversation
xma8lu
commented
Feb 3, 2025
•
edited
Loading
edited
action1: Readjust sUSDe-USDT<>USDT supply limit
modifier isSkippable(uint256 action_) { | ||
// If function is not skippable, then execute | ||
if (setActionSkippable[action_] == false) { | ||
_; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thrilok209 This won't work as expected right? We need a revert or something here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pradyuman-verma Why revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shriya updated this logic
i think @thrilok209 has already guided her to create this though maybe he can reconfirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it in remix, tx never reverts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pradyuman-verma shouldn't revert, should just skip the action