Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGP-83 #94

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

IGP-83 #94

wants to merge 30 commits into from

Conversation

xma8lu
Copy link
Contributor

@xma8lu xma8lu commented Feb 3, 2025

// Action1: Readjust sUSDe-USDT<>USDT supply limit
action1();

// Action 2: Raise fUSDC and fUSDT Rewards Allowance
action2();

// Action 3: Set launch limits for USDC collateral vaults
action3();

// Action 4: Set launch limits for ezETH-ETH DEX and ezETH<>wstETH T1 & ezETH-ETH<>wstETH T2 vaults
action4();

// Action 5: Update cbBTC-WBTC DEX configs
action5();

// Action 6: Update wstETH-ETH, weETH-ETH, rsETH-ETH DEX configs
action6();

// Action 7:Update USDC-USDT DEX limits
action7();

// Action 8: Set dust limits for USD0-USDC, fxUSD-USDC, USDC-BOLD DEX
action8();

Comment on lines 38 to 43
modifier isSkippable(uint256 action_) {
// If function is not skippable, then execute
if (setActionSkippable[action_] == false) {
_;
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thrilok209 This won't work as expected right? We need a revert or something here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradyuman-verma Why revert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shriya updated this logic
i think @thrilok209 has already guided her to create this though maybe he can reconfirm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it in remix, tx never reverts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradyuman-verma shouldn't revert, should just skip the action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants