Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add CI. #26

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Conversation

jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Oct 13, 2018

  • Add *.yml configuration files for CI.
  • Add Python wrapping files.
  • Update the README.rst file to reflect the CI status and Python
    installation steps.
  • Modify the current CTestConfig.cmake file to make the build results be
    sent to the Insight project in open.cdash.org.

Resolves #23.

@jhlegarreta
Copy link
Member Author

A few comments:

  • The CI builds will trigger many errors due to some of the facts pointed in Compiler error concerning ITK_THREAD_RETURN_VALUE #20 and Refactor the module #22, such as variable initialization, missing PrintSelf methods, etc. But I'd be for merging this, and then gradually fixing the rest of issues. At least this would allow us to be confident on our changes, and be a reminder of pending tasks.
  • The wrapping is sure not to be accurate; I certainly need some help and clarifications about it.

@jhlegarreta
Copy link
Member Author

Also pinging @phcerdan since he did lots of wrapping for his ITKIsotropicWavelets module. Thanks.

@jhlegarreta
Copy link
Member Author

Not sure whether classes templated only over the dimensionality have the correct wrapping, or else, other wrapping schemes like the one in itkLabelGeometryImageFilter.wrap should be used 😔

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent improvement! Minor comments inline.

itk-module.cmake Outdated Show resolved Hide resolved
itk-module.cmake Outdated Show resolved Hide resolved
- Add `*.yml` configuration files for CI.
- Add Python wrapping files.
- Update the `README.rst` file to reflect the CI status and Python
  installation steps.
- Modify the current `CTestConfig.cmake` file to make the build results be
  sent to the **Insight** project in **open.cdash.org**.
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely amazing @jhlegarreta ! 🎆

setup.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants