-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add CI. #26
ENH: Add CI. #26
Conversation
A few comments:
|
Also pinging @phcerdan since he did lots of wrapping for his ITKIsotropicWavelets module. Thanks. |
Not sure whether classes templated only over the dimensionality have the correct wrapping, or else, other wrapping schemes like the one in itkLabelGeometryImageFilter.wrap should be used 😔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent improvement! Minor comments inline.
- Add `*.yml` configuration files for CI. - Add Python wrapping files. - Update the `README.rst` file to reflect the CI status and Python installation steps. - Modify the current `CTestConfig.cmake` file to make the build results be sent to the **Insight** project in **open.cdash.org**.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely amazing @jhlegarreta ! 🎆
*.yml
configuration files for CI.README.rst
file to reflect the CI status and Pythoninstallation steps.
CTestConfig.cmake
file to make the build results besent to the Insight project in open.cdash.org.
Resolves #23.