itk 5.4.0 #78
Merged
itk 5.4.0 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thewtex
commented
Jun 5, 2024
thewtex
commented
- ENH: Update CI for ITK 5.4.0
- ENH: Migrate python packageing config to pyproject.toml
- ENH: Use setuptools_scm to set Python package version
dzenanz
reviewed
Jun 5, 2024
Uses scikit-build-core.
Based on Git tag and commits. Needs to be installed in requirements-dev.txt along with other build packages until: InsightSoftwareConsortium/ITKPythonPackage#276 InsightSoftwareConsortium/ITKPythonPackage#277 are released.
CI Windows test failures. CMake Warning at D:/a/ITKCuberille/ITK/CMake/ITKModuleExternal.cmake:15 (message): -- This is needed to allow proper setting of CMAKE_MSVC_RUNTIME_LIBRARY. -- Do not be surprised if you run into link errors of the style: LNK2038: mismatch detected for 'RuntimeLibrary': value 'MTd_Static' doesn't match value 'MDd_Dynamic' in module.obj cmake_minimum_required must be at least 3.16.3 Call Stack (most recent call first): CMakeLists.txt:7 (include)
dzenanz
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.