Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release [email protected] #44

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

leogail
Copy link
Collaborator

@leogail leogail commented Feb 6, 2024

Forgot to make a version

@parmentf
Copy link
Contributor

parmentf commented Feb 6, 2024

OK, it did not build (nor push) the docker image, because you did not push the tag.

git push --tags

That means you did not use the npm -w services/biblio-ref version minor way?

@leogail
Copy link
Collaborator Author

leogail commented Feb 7, 2024

First time, i saw you did a version 1.0.1 ; i though it was my new version so i didnt create one ; but it looks like it wasn't the newest version, that's why i created this PR

But if you talk about this version (1.1) :
I used the correct way. It failed beceause there wasn't distant remote.
So i created it and used "git push" but not git push --tags .

Copy link
Contributor

@parmentf parmentf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, now you only need to push the tag 👍

@leogail
Copy link
Collaborator Author

leogail commented Feb 15, 2024

forgot to push the tags..

@leogail leogail merged commit af97e35 into main Feb 15, 2024
2 checks passed
@leogail leogail deleted the services/biblio-ref/make-version branch February 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants