Merge pull request #36 from Inist-CNRS/fix/webhook-response

Send an empty response to acknowledge the webhook call
Inist-CNRS · May 13, 2024 · bdf9ef0 · bdf9ef0
2 parents ea85f70 + d8e3739
commit bdf9ef0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/tdm-be/src/controller/webhook.ts b/tdm-be/src/controller/webhook.ts
@@ -19,7 +19,8 @@ router.post(
             return;
         }
 
-        enrichmentHook.success(id);
+        enrichmentHook.success(id).then(undefined);
+        res.send();
     },
     (error) => {
         logger.error(error);
@@ -39,7 +40,8 @@ router.post(
             return;
         }
 
-        enrichmentHook.failure(id);
+        enrichmentHook.failure(id).then(undefined);
+        res.send();
     },
     (error) => {
         logger.error(error);

diff --git a/tdm-be/src/worker/enrichmentHook.ts b/tdm-be/src/worker/enrichmentHook.ts
@@ -210,9 +210,10 @@ const enrichmentHookFailure = async (processingId: string) => {
 };
 
 const catchEnrichmentHook = (enrichmentHook: { (processingId: string): Promise<void> }) => {
-    return (processingId: string) => {
-        const enrichmentPromise = enrichmentHook(processingId);
-        enrichmentPromise.catch((e) => {
+    return async (processingId: string) => {
+        try {
+            await enrichmentHook(processingId);
+        } catch (e) {
             const message = 'Receive an un-catch error from enrichment hook';
             error(processingId, 'Receive an un-catch error from enrichment hook');
             crash(e, message, processingId);
@@ -222,8 +223,10 @@ const catchEnrichmentHook = (enrichmentHook: { (processingId: string): Promise<v
                     return;
                 }
                 errorEmail(processing, ERROR_MESSAGE_ENRICHMENT_HOOK_UNEXPECTED_ERROR);
-            } catch (ignored) {}
-        });
+            } catch (ignored) {
+                /* empty */
+            }
+        }
     };
 };