Fix issue 104 #127
Open
Fix issue 104 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2020 12:58
parmentf
commented
Jan 26, 2021
| export const removeQuote = replace(/'/g, ' '); | ||
| /** | ||
| * Deplete string from accents, upper case, dash and simple quotes. | ||
| * @param {string} str | ||
| * @returns {string} | ||
| * @private | ||
| */ | ||
| export const depleteString = compose(toLower, removeAccents, removeQuote, removeDash, String); | ||
| export const depleteString = compose(toLower, removeQuote, removeDash, removeAccents, String); |
There was a problem hiding this comment.
Ça peut être dû à un encodage contenant un tiret (que removeDash supprime), donc pourquoi pas?
parmentf
commented
Jan 27, 2021
Replaced arr with indexes in contain.
target has not to be sorted, its tokens' order is important, though.
isIn takes only one argument, the second was thus useless.
Add the types, and clarify comment.
It was not taking into account the longer labels or numeros.
parmentf
commented
Jan 27, 2021
Use the previous hasSigle, to prevent false positives.
|
Tant qu'on n'aura pas précisé le but de cette intervention, ce n'est pas la peine d'intégrer cette Pull Request dans la branche master: il ne reste qu'une modification mineure, qui ne change rien aux tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Pull Request to integrate the fix-issue-104 branch into the master branch.
It was intended to fix #104, but the issue does not contain any description of the problem.
Nor does the branch add or modify a test, so it's hard to know what has to be fixed.