Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: published filter has hits when unpublished concept has earlier p… #399

Conversation

NilsOveTen
Copy link
Contributor

…ublished version

fixes #396

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.06%. Comparing base (f78f6da) to head (0c0279b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...n/no/fdk/concept_catalog/elastic/ElasticUpdater.kt 0.00% 8 Missing ⚠️
...n/no/fdk/concept_catalog/service/ConceptService.kt 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #399      +/-   ##
============================================
- Coverage     84.35%   84.06%   -0.30%     
+ Complexity      477      471       -6     
============================================
  Files            52       52              
  Lines          1771     1770       -1     
  Branches        279      277       -2     
============================================
- Hits           1494     1488       -6     
- Misses          123      129       +6     
+ Partials        154      153       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NilsOveTen NilsOveTen force-pushed the fix/not/published-filter-hits-when-concept-has-earlier-published-version branch from 86c538f to 1340302 Compare November 26, 2024 15:27
@NilsOveTen NilsOveTen force-pushed the fix/not/published-filter-hits-when-concept-has-earlier-published-version branch from 1340302 to 048e659 Compare November 27, 2024 09:41
@NilsOveTen NilsOveTen merged commit 4e68f08 into main Nov 29, 2024
5 of 7 checks passed
@NilsOveTen NilsOveTen deleted the fix/not/published-filter-hits-when-concept-has-earlier-published-version branch November 29, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

published-filter skal også få treff om det finnes tidligere versjoner som har blitt publisert
2 participants