Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle db null values in array of subject codes #301

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

NilsOveTen
Copy link
Contributor

No description provided.

@NilsOveTen NilsOveTen requested a review from a team November 21, 2023 07:28
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5aa70cd) 83.90% compared to head (5a33ca9) 83.29%.

Files Patch % Lines
...lin/no/fdk/concept_catalog/model/CurrentConcept.kt 0.00% 0 Missing and 1 partial ⚠️
...n/no/fdk/concept_catalog/service/ConceptMappers.kt 0.00% 0 Missing and 1 partial ⚠️
...dk/concept_catalog/service/SkosApNoModelService.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #301      +/-   ##
============================================
- Coverage     83.90%   83.29%   -0.62%     
+ Complexity      463      460       -3     
============================================
  Files            51       51              
  Lines          1628     1628              
  Branches        254      256       +2     
============================================
- Hits           1366     1356      -10     
- Misses          122      129       +7     
- Partials        140      143       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NilsOveTen NilsOveTen merged commit 2305c7c into main Nov 21, 2023
4 of 6 checks passed
@NilsOveTen NilsOveTen deleted the fix/not/handle-null-subject-code branch November 21, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants