Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom TLS certificate support #43

Merged
merged 17 commits into from
Jul 29, 2024

Conversation

DanielHougaard
Copy link
Collaborator

This PR introduces support for custom / self-signed certificates that aren't present in the root store or webPKI store.

The user is given two options on how they want to pass in the certificate

  1. The path to the certificate. This is passed when initializing the Infisical client in the respective language.
  2. An environment variable containing the full certificate. If no path is provided, we check internally for an environment variable containing the certificate.

There are quite a few files changed, because we need to ensure all the requests being sent by the SDK is covered by the TLS support.

There's a new build_minimal_base_request function, which doesn't factor in the SSL certificate. This function is used when sending requests to non-Infisical hosts like GCP or AWS.

@DanielHougaard DanielHougaard requested a review from maidul98 July 23, 2024 21:00
@DanielHougaard DanielHougaard self-assigned this Jul 23, 2024
@DanielHougaard DanielHougaard requested review from akhilmhdh and removed request for maidul98 July 23, 2024 21:44
@DanielHougaard DanielHougaard merged commit a95b3f8 into main Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants