Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove set cache and use unwrap_or #14

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Remove set cache and use unwrap_or #14

merged 1 commit into from
Jan 17, 2024

Conversation

rustaceanrob
Copy link
Contributor

Removes an old function per suggestion and uses an unwrap_or. Also adds an exception message if the Option is None somehow.

@rustaceanrob rustaceanrob temporarily deployed to infisical-test-workspace January 17, 2024 04:29 — with GitHub Actions Inactive
DanielHougaard
DanielHougaard approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@DanielHougaard DanielHougaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will be added as a part of the next release :-)

@DanielHougaard DanielHougaard merged commit 7be9328 into Infisical:main Jan 17, 2024
1 of 2 checks passed
@rustaceanrob rustaceanrob deleted the change-client branch January 17, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHougaard DanielHougaard DanielHougaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustaceanrob @DanielHougaard