Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Setup Password #3052

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Feature: Setup Password #3052

merged 3 commits into from
Jan 28, 2025

Conversation

scott-ray-wilson
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson commented Jan 28, 2025

Description 📣

This PR adds support to setup a password for users who signed up via methods other than email/password. Also updates reset password from backup key to store hashed password.

PR also includes adjustments to Secret Syncs layout to conform to nav restructure.

CleanShot 2025-01-27 at 18 52 41@2x

CleanShot 2025-01-27 at 18 52 01@2x

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

Copy link
Member

@akhilmhdh akhilmhdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may also need to tell users in the email they must be logged in do this -

Because felt it quite confusing, when it's was just back to login page.

backend/src/services/auth/auth-password-service.ts Outdated Show resolved Hide resolved
…t and only add email auth method if not already present
@scott-ray-wilson scott-ray-wilson merged commit 955cf93 into main Jan 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants