Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : TeamCty Integration error #2882

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mhammad-riyaz
Copy link

Description 📣

Problem:
When performing a TeamCity integration, after entering the access token and server URL, the page errors out upon clicking the "Connect" button.

Root Cause:
In the create.tsx file, the targetBuildConfigs array is being concatenated with an object containing configId and configName initialized to empty strings (filteredBuildConfigs). This modified array is then passed to the Select component. However, the SelectItem component does not accept empty strings as valid values, which leads to the error.

Solution:
Removed the addition of the empty configId and configName object to the targetBuildConfigs array.
This ensures that only valid build configurations are passed to the Select component, preventing the error from occurring.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

infisical-teamcity-integration.mp4
            {targetBuildConfigs.map((buildConfig: any) => (
              <SelectItem
                value={buildConfig.buildConfigId}
                key={`target-build-config-${buildConfig.buildConfigId}`}
              >
                {buildConfig.name}
              </SelectItem>
            ))}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant