fix: secrets being deleted

Infisical · Feb 7, 2025 · bae3cfb · bae3cfb
1 parent 8ce1315
commit bae3cfb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/backend/src/services/secret-sync/azure-app-configuration/azure-app-configuration-sync-fns.ts b/backend/src/services/secret-sync/azure-app-configuration/azure-app-configuration-sync-fns.ts
@@ -138,13 +138,12 @@ export const azureAppConfigurationSecretSyncFactory = ({
 
     for await (const key of Object.keys(azureAppConfigSecrets)) {
       const azureSecret = azureAppConfigSecrets[key];
-      if (!(key in secretMap) || secretMap[key] === null || azureSecret.label !== secretSync.destinationConfig.label) {
-        await $deleteAzureSecret(
-          accessToken,
-          secretSync.destinationConfig.configurationUrl,
-          key,
-          azureSecret.label // use the secret's actual label for deletion
-        );
+      if (
+        !(key in secretMap) ||
+        secretMap[key] === null ||
+        (azureSecret.label && azureSecret.label !== secretSync.destinationConfig.label)
+      ) {
+        await $deleteAzureSecret(accessToken, secretSync.destinationConfig.configurationUrl, key, azureSecret.label);
       }
     }
   };

diff --git a/backend/src/services/secret-sync/azure-key-vault/azure-key-vault-sync-fns.ts b/backend/src/services/secret-sync/azure-key-vault/azure-key-vault-sync-fns.ts
@@ -238,7 +238,8 @@ export const azureKeyVaultSecretSyncFactory = ({
 
     Object.keys(vaultSecrets).forEach((key) => {
       if (!disabledAzureKeyVaultSecretKeys.includes(key)) {
-        secretMap[key] = {
+        const underscoredKey = key.replace(/-/g, "_");
+        secretMap[underscoredKey] = {
           value: vaultSecrets[key].value
         };
       }