Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make pack recipe compatible with py2 & py3 #3

Closed
wants to merge 1 commit into from
Closed

make pack recipe compatible with py2 & py3 #3

wants to merge 1 commit into from

Conversation

freddrake
Copy link
Contributor

No description provided.

@freddrake freddrake mentioned this pull request Sep 17, 2019
Open
@wiggin15
Copy link
Contributor

Thanks for the PR!
We do still want to support Python 2.7 (for the little time it has left), but support for Python <2.7 is not needed. Since the "filter" parameter exists in Python 2.7, I think we don't really need to check whether the Python version is 2 or 3, and use "exclude"/"filter" according to this check, but rather we can just switch to use the newer "filter" parameter and change the filter method accordingly.

@freddrake
Copy link
Contributor Author

That makes sense to me! No need for this PR them; the original patch @Edward-Knight sent via Infinidat/relocatable-python3#8 should probably be applied instead.

@freddrake freddrake closed this Sep 17, 2019
@freddrake
Copy link
Contributor Author

I see @Edward-Knight also provided his patch in issue #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freddrake @wiggin15