Refactor doNotGoToSleep to a wakelock counter #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
|
Couple rebase mistakes breaking build I'll patch them this evening |
|
Rebased to resolve conflicts |
NeroBurner
requested changes
Sep 18, 2024
JF002
approved these changes
Sep 21, 2024
NeroBurner
added a commit
to InfiniTimeOrg/InfiniSim
that referenced
this pull request
Sep 21, 2024
For InfiniTime PR InfiniTimeOrg/InfiniTime#2107 a new systemtask file is introduced `WakeLock.h` and `WakeLock.cpp`. If available add those files to the build target to support the current `main` and the new `WakeLock` using redesign.
NeroBurner
added a commit
to InfiniTimeOrg/InfiniSim
that referenced
this pull request
Sep 21, 2024
For InfiniTime PR InfiniTimeOrg/InfiniTime#2107 a new systemtask file is introduced `WakeLock.h` and `WakeLock.cpp`. If available add those files to the build target to support the current `main` and the new `WakeLock` using redesign.
NeroBurner
requested changes
Sep 21, 2024
There was a problem hiding this comment.
I've updated the InfiniSim to use WakeLock.cpp if it is available, fixing this PR build pipeline
InfiniTimeOrg/InfiniSim#150
Just the little newline and we're good to go from my side
NeroBurner
added a commit
to InfiniTimeOrg/InfiniSim
that referenced
this pull request
Sep 21, 2024
For InfiniTime PR InfiniTimeOrg/InfiniTime#2107 a new systemtask file is introduced `WakeLock.h` and `WakeLock.cpp`. If available add those files to the build target to support the current `main` and the new `WakeLock` using redesign.
|
merge conflict after #2109 got merged. Please resolve them when doing the little newline |
|
I also moved the destructor as IMO code should be minimally surprising, and now I think about it you don't really expect to find code in the header (except maybe const getters) |
|
I always miss those formatting errors when rebasing... |
NeroBurner
approved these changes
Sep 21, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than tracking whether sleeping is disabled with a boolean, this moves it to a counter which records the number of requests to keep the device awake. When this counter is zero, sleeping is possible. This prevents one task from enabling sleeping when another task still wants sleeping disabled.