Fixes for PR 2046 (SPI transaction hooks) #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF002
approved these changes
May 1, 2024
There was a problem hiding this comment.
I've just merge InfiniTimeOrg/InfiniTime#2046 so I guess we can merge this one too!
|
I still need to update this for the final version of SPI hooks we went with, don't merge just yet! |
|
Should be ready to go now, builds for me against latest main (when including #142 ) |
|
Could you update this PR to also update the submodule reference to the latest main state of InfiniTime that works with this PR. Afterwards I'll merge right away. Thanks for the fix! |
NeroBurner
added
the
needs-InfiniTime-change
|
Rebased on main and updated submodule to InfiniTime main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion for InfiniTimeOrg/InfiniTime#2046