issue/176: 支持macos编译 #178
Closed
issue/176: 支持macos编译 #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanZezhong1725
requested changes
Apr 21, 2025
scripts/install.py
Outdated
| @@ -2,23 +2,89 @@ | |||
| import subprocess | |||
| import platform | |||
| import sys | |||
| from set_env import set_env | |||
| # 尝试导入 set_env，如果失败则定义一个空函数 | |||
| try: | |||
There was a problem hiding this comment.
这个别这么写，最好是给set_env加一个支持macos平台的功能
scripts/install.py
Outdated
| user_provided_flags = " ".join(sys.argv[1:]) | ||
| print(f"User provided flags: '{user_provided_flags}'") | ||
| install(user_provided_flags) | ||
| print("--- InfiniCore Installation Script Finished ---") |
scripts/install.py
Outdated
| install(" ".join(sys.argv[1:])) | ||
| print("--- Starting InfiniCore Installation Script ---") | ||
| print("Setting up environment variables...") | ||
| try: |
There was a problem hiding this comment.
不要加try catch，这个函数出错直接退
| f"{new_lib_path}:{os.environ.get('LD_LIBRARY_PATH', '')}" | ||
| ) | ||
| """ | ||
| Sets up environment variables for Infini software, supporting Windows, Linux, and macOS. |
There was a problem hiding this comment.
请按照之前的格式写，不同平台不要串在一起
src/infiniop-test/include/test.hpp
Outdated
| @@ -99,7 +99,7 @@ class Test { | |||
| \ | |||
| std::string toString() const override; \ | |||
| \ | |||
| ~Test(); \ | |||
| virtual ~Test(); \ | |||
| libop_path = find_library_in_infini_root("lib", "libinfiniop.dylib") | ||
| librt_path = find_library_in_infini_root("lib", "libinfinirt.dylib") | ||
| else: | ||
| raise RuntimeError(f"Unsupported operating system: {system_name}") | ||
|
|
||
| assert ( |
There was a problem hiding this comment.
把这个检查和打印信息直接放helper里吧
| @@ -98,4 +113,4 @@ def find_library_in_ld_path(subdir, library_name): | |||
| lib.infinirtSetDevice.argtypes = [c_int, c_int] | |||
| lib.infinirtSetDevice.restype = c_int | |||
|
|
|||
| return lib | |||
| return lib | |||
src/infiniop/ops/gemm/info.h
Outdated
| BlasMatrix a_matrix; | ||
| BlasMatrix b_matrix; | ||
| BlasMatrix c_matrix; | ||
|
|
||
| size_t m, n, k, batch; | ||
| bool is_transed; | ||
|
|
||
| private: |
There was a problem hiding this comment.
能不能把这个放前面。如果用这个，是不是该删了 MatmulInfo() = default;
| @@ -47,4 +55,4 @@ infiniStatus_t Descriptor::calculate( | |||
| return INFINI_STATUS_SUCCESS; | |||
| } | |||
|
|
|||
| } // namespace op::rearrange::cpu | |||
src/infiniop/ops/gemm/info.h
Outdated
| static utils::Result<MatmulInfo> create( | ||
| infiniopTensorDescriptor_t c_desc, | ||
| infiniopTensorDescriptor_t a_desc, | ||
| infiniopTensorDescriptor_t b_desc, | ||
| MatrixLayout layout) { | ||
|
|
||
| auto a_matrix = BlasMatrix::create(a_desc); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.