Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 3: Uncontrolled data used in path expression #651

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wagmarcel
Copy link
Member

Fixes https://github.com/IndustryFusion/DigitalTwin/security/code-scanning/3

To fix the problem, we need to ensure that the filename parameter is validated and sanitized before it is used to construct the file path. We can achieve this by normalizing the path and ensuring it is contained within a safe root directory. Additionally, we can use a library like sanitize-filename to remove any special characters from the filename.

  1. Import the sanitize-filename library.
  2. Normalize the path using path.resolve to remove any ".." segments.
  3. Check that the normalized path starts with the root directory.
  4. If the path is invalid, return an error response.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@wagmarcel
Copy link
Member Author

@dependabot rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant