Fix code scanning alert no. 3: Uncontrolled data used in path expression #651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/IndustryFusion/DigitalTwin/security/code-scanning/3
To fix the problem, we need to ensure that the
filename
parameter is validated and sanitized before it is used to construct the file path. We can achieve this by normalizing the path and ensuring it is contained within a safe root directory. Additionally, we can use a library likesanitize-filename
to remove any special characters from the filename.sanitize-filename
library.path.resolve
to remove any ".." segments.Suggested fixes powered by Copilot Autofix. Review carefully before merging.