change: remove dev-only defaults #394
Conversation
add: random minio secret
| lagoon: | ||
| env: | ||
| FIELD_AUTOCONFIRM_CONFIDENCE: 0.8 | ||
| FIELD_CONFIG_PATH: "fields_config.yaml" | ||
| ask-my-docs: |
There was a problem hiding this comment.
im not convinced this is correct either since it means all clusters will spin up using our dev openai creds, which feels wrong
Yes, by creating a new cluster using this branch |
| storage: | ||
| accessKey: <path:tools/argo/data/indico-dev/ins-dev/storage#access_key_id> | ||
| secretKey: <path:tools/argo/data/indico-dev/ins-dev/storage#secret_access_key> | ||
| accessKey: ${random_password.minio-username.result} |
There was a problem hiding this comment.
Looks like the secrets being referenced here are AWS credentials to connect to a storage bucket. Is it okay to set these as minio:<random_password>?
Have you tested deploying a cluster with this change?
There was a problem hiding this comment.
they configure the root username & password for minio, not to an external s3 iam user
| # TODO: enable this when we have a backup bucket | ||
| # 1 less than the hard limit of the weaviate node group type | ||
| GOMEMLIMIT: "31GiB" | ||
| # TODO: switch this to a dedicated weaviate backup bucket | ||
| backups: |
There was a problem hiding this comment.
Whoops, looks like we'll need to change the backup configuration for Azure, it shouldn't be pointing to s3
There was a problem hiding this comment.
weaviate backs up to minio, not s3
given that we're getting rid of weaviate soon, i figured it didn't matter much
also add a random minio secret instead of pulling from vault
not super sure how to test changes here or why the pr checks are failing. spin up a new cluster?