[DOP-2361] Fix for allowing disabling thanos #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han using exec command, which seems to be timing out to the local cluster.
…urce. Soft disable thanos for Azure clusters as well. Leave thanos_enabled set true for now to prevent errors on clusters already running thanos.
…urce. Restore thanos settings to allow togging between being enabled or disabled. Update thanos_enabled to be false by default.
…ault, but comment out all settings to cause thanos to be disabled..
ashmuck
approved these changes
Oct 31, 2024
| @@ -642,7 +642,7 @@ variable "thanos_cluster_name" { | |||
|
|
|||
| variable "thanos_enabled" { | |||
| type = bool | |||
| default = false | |||
| default = true | |||
There was a problem hiding this comment.
Should we just remove this variable altogether?
| args = ["eks", "get-token", "--cluster-name", var.label] | ||
| command = "aws" | ||
| } | ||
| token = data.aws_eks_cluster_auth.local.token |
There was a problem hiding this comment.
Hope this is the permanent fix!
| @@ -791,7 +791,7 @@ variable "indico_devops_aws_region" { | |||
|
|
|||
| variable "thanos_enabled" { | |||
| type = bool | |||
| default = false | |||
| default = true | |||
There was a problem hiding this comment.
ditto here for removing the variable
There was a problem hiding this comment.
I intentionally left all the code commented out, so that it would be easy to turn this feature back on in the future. So, I was thinking that it would be better to keep the variable, rather than removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.