-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new attribute shorthand #173
Support new attribute shorthand #173
Conversation
Getting an npm error on
|
Hey sorry I totally missed this. Could you turn this into separate PRs, one that does the grammar updates (for the shorthand) and a separate one doing the support/CI/gitignore/etc updates? The grammar updates is small and looks great to me, everything else needs some more discussion. |
No worries, should get to this by EOW |
@tgross35 this should be ready to review once more |
https://github.com/IndianBoy42/tree-sitter-just/actions/runs/11768782768/job/32778994256?pr=173 should generated code be omitted from formatting? |
bindings/node/binding_test.js
Outdated
@@ -0,0 +1,9 @@ | |||
/// <reference types="node" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do these new tests in bindings
work? They don't seem to be getting run in CI.
I would rather put these new tests in a separate PR if possible, along with a check in CI via the root justfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something created by tree-sitter
cli with the latest version, I will try to see where this is created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, interesting. No worries then, it can stick around if it's the same version used in CI (which should probably be bumped)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually unable to produce the bindings_test.js
, I've deleted the file :\
Irc there was an issue at some point where TS generated slightly different formatting for different platforms. In any case it doesn't hurt to keep things uniform, and I think |
@tgross35 I ran |
I just updated all the versions and I can't get |
6fc6bfc
to
6763844
Compare
6763844
to
bc7a9b1
Compare
c8c4204
to
8a73365
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks!
Added support for new attribute shorthand:
https://github.com/casey/just/blob/fa5770e71aa93402068ebc9e179e493fc94f8532/tests/attributes.rs#L202-L205