Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new attribute shorthand #173

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support new attribute shorthand #173

wants to merge 3 commits into from

Conversation

mkatychev
Copy link
Contributor

Added support for new attribute shorthand:

[attr_key: "value"]
foo:
  echo "bar"

https://github.com/casey/just/blob/fa5770e71aa93402068ebc9e179e493fc94f8532/tests/attributes.rs#L202-L205

mkatychev
mkatychev commented Aug 27, 2024
View reviewed changes
test/corpus/recipes.txt
@@ -551,7 +551,7 @@ recipes containing attributes with arguments
================================================================================


[group("foo"), group("echo")]
[group("foo"), group: "echo"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the s-expr should not change at all since this is an alternative form of the same statement

@mkatychev
Copy link
Contributor Author

Getting an npm error on just lint:

npm run lint:check
npm error Missing script: "lint:check"
npm error
npm error To see a list of scripts, run:
npm error   npm run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkatychev