Skip to content

Commit

Permalink
Still diff files that show up as binary but are text
Browse files Browse the repository at this point in the history
CI currently says "Binary files a/src/node-types.json and b/src/node-types.json differ", but we would like some more useful information here.
  • Loading branch information
tgross35 committed May 1, 2024
1 parent f70a36d commit 72937dd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ on:
workflow_dispatch:
pull_request:
push:
branches: [main]

env:
RUST_BACKTRACE: 1
Expand Down
2 changes: 1 addition & 1 deletion justfile
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ ci-validate-generated-files exit-code="1":
just {{ verbose_flag }} gen

failed=false
git diff ci-tmp-pre-updates --exit-code || failed=true
git diff ci-tmp-pre-updates --text --exit-code || failed=true
git tag -d ci-tmp-pre-updates

if ! [ "$failed" = "false" ]; then
Expand Down

0 comments on commit 72937dd

Please sign in to comment.