Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depends section from schemas #694

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

dalonsoa
Copy link
Collaborator

Description

Remove the depend section from all the schemas, which was a leftover from the previous approach and that is no longer relevant after implementing the variables system in full. The documentation is updated accordingly.

Fixes #660

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (7838fa8) to head (d2868c0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #694   +/-   ##
========================================
  Coverage    94.60%   94.60%           
========================================
  Files           73       73           
  Lines         4800     4800           
========================================
  Hits          4541     4541           
  Misses         259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sallymatson sallymatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant depends sections from model schema
4 participants