Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant basemodelsetup #667

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sallymatson
Copy link
Collaborator

Description

Removed depreciated setup method of the BaseModel, and references throughout the codebase.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@sallymatson sallymatson linked an issue Jan 10, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (913a228) to head (200851a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #667      +/-   ##
===========================================
- Coverage    94.57%   94.56%   -0.02%     
===========================================
  Files           73       73              
  Lines         4645     4634      -11     
===========================================
- Hits          4393     4382      -11     
  Misses         252      252              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant BaseModel.setup method
2 participants