Revert "Bump numpy from 2.1.3 to 2.2.0 in the production-dependencies group" #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #641 +/- ##
========================================
Coverage 94.62% 94.62%
========================================
Files 73 73
Lines 4617 4617
========================================
Hits 4369 4369
Misses 248 248 ☔ View full report in Codecov by Sentry. |
vgro
approved these changes
Dec 16, 2024
davidorme
deleted the
revert-639-dependabot/pip/production-dependencies-19ddaf9521
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #639
Numpy 2.2.0 changes some typing handling that raises issues - this failed
pre-commit.cias a result but that check wasn't required. So I'm backing this one off until it can pass.I've made
pre-commit.cione of the required checks now - but because of the way it runs, we're getting that same failure. I'll have to force this push, but does this seem reasonable?