-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding nitrogen mineralisation #616
Adding nitrogen mineralisation #616
Conversation
…solved and particulate forms
…ecular weight carbon
…ple classes of pool
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #616 +/- ##
===========================================
- Coverage 95.18% 95.16% -0.02%
===========================================
Files 74 74
Lines 4380 4409 +29
===========================================
+ Hits 4169 4196 +27
- Misses 211 213 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a couple of comments/suggestions, but it looks good, otherwise.
… integrated by the soil model integration
… docstring of the function to be integrated
@dalonsoa, I've tried to address all your suggestions. Let me know whether the changes look okay. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good!
Co-authored-by: Diego Alonso Álvarez <[email protected]>
Description
This pull request adds two new pools to track nitrogen in the soil "soil_n_pool_don" and "soil_n_pool_particulate". These pools both receive input from litter mineralisation, and the DON (dissolved organic nitrogen) pool also leaches. Both pools are organic nitrogen pools, so effectively track the nitrogen stoichiometry of their corresponding carbon pools (the low molecular weight carbon (LMWC) pool and the particulate organic matter (POM) pool). The breakdown rate of POM to LMWC therefore determines the rate at which nitrogen goes from the particulate to the dissolved pool.
I've also tried to restructure the code a bit. I've added a new
SoilPools
class, which has method to calculate updates for all soil pools. I still feel like the contents of this method is a bit messy, but I couldn't see an obvious way to group the function steps that would make it clearer. I'm leaving this as is for now, but intended to refactor as further pools are addedFixes #605
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks