Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant BaseModel.setup method #665

Open
davidorme opened this issue Jan 10, 2025 · 0 comments · May be fixed by #667
Open

Remove redundant BaseModel.setup method #665

davidorme opened this issue Jan 10, 2025 · 0 comments · May be fixed by #667
Assignees
@sallymatson

Comments

@davidorme
Copy link
Collaborator

With the new organisation of the the BaseModel, the setup method has been retired. The method is still defined in core.base_model.BaseModel and all of the models still have stub implementations. We can now remove all of these.
@davidorme davidorme assigned davidorme and sallymatson and unassigned davidorme Jan 10, 2025
@sallymatson sallymatson linked a pull request Jan 10, 2025 that will close this issue
Remove redundant basemodelsetup #667
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sallymatson sallymatson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant basemodelsetup ImperialCollegeLondon/virtual_ecosystem
2 participants
@davidorme @sallymatson