Link data import objects with Measurements and Reports #384
+125
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR links the
DataImportobjects with the actualMeasuremententries they generate and, to some extent, to the associatedReportobjects obtained after validation. This way, when aDataImportobject is deleted or re-processed, the related data can be easily found and removed (automatically, as they have a CASCADE relation).I've kept the deletion step based on time range, as some data - specially initial data or that migrated from the current system - will not have an associated
DataImportobject. Also, the deletion of theReportobjects is not accurate as reports might combine data from multipleDataImports, and not being deleted if the wrongDataImport, based on the mode of the data used for the calculation, is associated with that entry. So, again, the deletion based on the time range comes handy.Close #338