Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 193 class based annotation toggle #212

Merged
merged 4 commits into from
May 28, 2024

Conversation

pedrokohler
Copy link
Collaborator

Adding the ability to toggle annotation groups based on their categories and types. Solves #193.

Screenshare.-.2024-05-16.4_15_04.PM.mp4

image

@pedrokohler pedrokohler requested a review from igoroctaviano May 17, 2024 14:26
Copy link

github-actions bot commented May 17, 2024

Visit the preview URL for this PR (updated for commit 50adbcc):

https://idc-external-006--pr212-feat-193-class-based-fhb4a8s9.web.app

(expires Tue, 04 Jun 2024 15:18:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

Copy link
Collaborator

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@pedrokohler check the failed build and update the branch with master.
After that, test the preview URL and send it to @fedorov for testing.

@fedorov
Copy link
Member

fedorov commented May 25, 2024

I am traveling this coming week, so please feel free to ping me on slack if you need feedback and I do not respond here!

@pedrokohler pedrokohler requested a review from igoroctaviano May 28, 2024 15:09
Copy link
Collaborator

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igoroctaviano igoroctaviano merged commit ec94737 into master May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants