Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce ruff/bugbear rules (B) #286

Merged
merged 7 commits into from
Jun 15, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 28, 2024

This is a suggestion of Scientific Python Repo-Review.

B018 Found useless expression. Either assign it to a variable or remove it.
B009 Do not call `getattr` with a constant attribute value.
     It is not any safer than normal property access.
B010 Do not call `setattr` with a constant attribute value.
     It is not any safer than normal property access.
B032 Possible unintentional type annotation (using `:`).
     Did you mean to assign (using `=`)?
B904 Within an `except` clause, raise exceptions with `raise ... from err` or
     `raise ... from None` to distinguish them from errors in exception handling
B007 Loop control variable not used within loop body
B028 No explicit `stacklevel` keyword argument found
Copy link
Collaborator

@CPBridge CPBridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CPBridge CPBridge merged commit 7abac6b into ImagingDataCommons:master Jun 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants