Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a list from a list is equivalent to a copy #261

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

In that case, I find calling .copy() is more readable.

However, do we really need this copy? The list unique_instance_data is initialised in this function and then returned. What's the point of copying it?

In that case, I find calling .copy() is more readable.
src/highdicom/seg/sop.py Outdated Show resolved Hide resolved
@CPBridge CPBridge merged commit b63a2ad into ImagingDataCommons:master Oct 11, 2023
11 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the list_copy branch October 11, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants